Closed wetted closed 1 year ago
it was failing for me locally as well. I have fixed the tests.
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Catch issues before they fail your Quality Gate with our IDE extension SonarLint
I still think
static {
MY_KAFKA = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:latest"))
MY_KAFKA.start()
}
Is an anti-pattern especially in Spock tests
I still think
static { MY_KAFKA = new KafkaContainer(DockerImageName.parse("confluentinc/cp-kafka:latest")) MY_KAFKA.start() }
Is an anti-pattern especially in Spock tests
Please, @timyates send an additional PR.
824
@sdelamo @timyates The reason I wasn't using the
AbstractKafkaTest
in my new examples, but left it is because the docs recommend usingmicronaut-test-resources
which is what I intended for new examples. However, the docs have a section and example of using Testcontainers directly, thusAbstractKafkaTest
. See https://micronaut-projects.github.io/micronaut-kafka/latest/guide/#kafkaDockerized
We need the same fix for the Java and Kotlin AbstractKafkaTest
docs examples. I'll do that on my next PR.
@sdelamo @timyates I'm puzzled why the test-suite test case fails. It passes locally for me every time. Ugh.