search

micronaut-projects / micronaut-kafka

Integration between Micronaut and Apache Kafka
Apache License 2.0
86 stars 107 forks source link

Multi-language docs examples for Kafka Streams #839

Closed wetted closed 1 year ago

guillermocalvo commented 1 year ago

LGTM 👍

sdelamo commented 1 year ago

LGTM 👍

@guillermocalvo Please, use the GitHub review PR functionality to signal whether you approve, reject or leave comments in a PR.

guillermocalvo commented 1 year ago

@guillermocalvo Please, use the GitHub review PR functionality to signal whether you approve, reject or leave comments in a PR.

@sdelamo I left a comment because at the time the PR was not ready for review yet. Do you guys usually approve/reject draft PRs? I can do that next time.

sdelamo commented 1 year ago

@guillermocalvo Please, use the GitHub review PR functionality to signal whether you approve, reject or leave comments in a PR.

@sdelamo I left a comment because at the time the PR was not ready for review yet. Do you guys usually approve/reject draft PRs? I can do that next time.

no, we don't review Draft PRs generally.

guillermocalvo commented 1 year ago

no, we don't review Draft PRs generally.

@sdelamo That's what I thought, which is why I left a comment in the draft PR to indicate that it looked good to me so far.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication