micronaut-projects / micronaut-maven-plugin

Maven plugin to execute Micronaut applications
https://micronaut-projects.github.io/micronaut-maven-plugin/latest/
Apache License 2.0
21 stars 22 forks source link

Support reading Jib configuration for ports #1229

Closed alvarosanchez closed 3 weeks ago

alvarosanchez commented 3 weeks ago

Fixes: #1218

alvarosanchez commented 3 weeks ago

The only thing which bothers me a bit is the introduction of a dependency on Jackson.

I resisted as much as I could, but working with the Xpp3Dom API is unsustainable 😞

That being said, this reminds me that Jackson is perhaps already in the classpath. I will verify it

alvarosanchez commented 3 weeks ago

@melix I was right, Jackson was already on the classpath. The latest commit ensures that the version is aligned.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud