micronaut-projects / micronaut-serialization

Build Time Serialization APIs for Micronaut

Apache License 2.0

26 stars 18 forks source link

Decouple Micronaut Modules from Jackson #39

Open graemerocher opened 3 years ago

graemerocher commented 3 years ago

[ ] micronaut-gcp
[x] micronaut-problem-json [ ] ❌ #94
[ ] micronaut-discovery-client
[x] micronaut-rabbitmq
[x] micronaut-security
[ ] micronaut-data
[x] micronaut-mqtt
[x] micronaut-nats
[x] micronaut-liquibase
[x] micronaut-pulsar
[ ] micronaut-aws
[x] micronaut-jms
[x] micronaut-sql
[x] micronaut-graphql
[x] micronaut-kafka

Micronaut GCP

Micronaut Problem JSON

https://github.com/micronaut-projects/micronaut-problem-json/blob/29f4645bf1244c9c3079053778be3e6ab1899fb1/problem-json/src/main/java/io/micronaut/problem/conf/MixInThrowableProblem.java

Micronaut Discovery Client

Significant uses of Jackson DataBind for Consul/Eureka (https://github.com/micronaut-projects/micronaut-discovery-client/blob/3d6c214f8652d9858580ac0e07e98d4563e9c545/discovery-client/src/main/java/io/micronaut/discovery/consul/client/v1/KeyValue.java) probably best to add a dependency on the data bind module

Micronaut RabbitMQ

https://github.com/micronaut-projects/micronaut-rabbitmq/blob/97d228b042c30c71e1665f51f9bfacbf346736ae/rabbitmq/src/main/java/io/micronaut/rabbitmq/serdes/JsonRabbitMessageSerDes.java

Micronaut Security

Micronaut Data

Micronaut MQTT

https://github.com/micronaut-projects/micronaut-mqtt/blob/cf4adeb37df9a0abcff6cdaff8aa9cb5c47740c3/mqtt-core/src/main/java/io/micronaut/mqtt/serdes/JsonMqttPayloadSerDes.java

Micronaut NATs

https://github.com/micronaut-projects/micronaut-nats/blob/09dcdf363de4729840087820ff4feb0b24f0e4ee/nats/src/main/java/io/micronaut/nats/serdes/JsonNatsMessageSerDes.java

Micronaut Liquibase

https://github.com/micronaut-projects/micronaut-liquibase/blob/2c2da5ffd41b5f1ea09fcfe9d9791c0134ad8bdd/liquibase/src/main/java/io/micronaut/liquibase/endpoint/RanChangeSetSerializer.java

Micronaut Pulsar

Micronaut AWS

https://github.com/micronaut-projects/micronaut-aws/blob/222f6025a66500d692ba1de570de8f186993df0d/function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/AbstractLambdaContainerHandler.java

Micronaut JMS

Micronaut SQL

https://github.com/micronaut-projects/micronaut-sql/blob/5fda28e2392ae3bd6d30420bff76bb0046a2d2cf/jooq/src/main/java/io/micronaut/configuration/jooq/JacksonConverterProvider.java

Micronaut GraphQL

https://github.com/micronaut-projects/micronaut-graphql/blob/1baa6e48b1cf60037478c3e15e207583402e009b/graphql/src/main/java/io/micronaut/configuration/graphql/JacksonGraphQLJsonSerializer.java

Micronaut Kafka

https://github.com/micronaut-projects/micronaut-kafka/blob/66fd3b7248f76b3ee15e5a015e9289c38d3af390/kafka/src/main/java/io/micronaut/configuration/kafka/serde/JsonSerde.java

yawkat commented 2 years ago

[x] https://github.com/micronaut-projects/micronaut-problem-json/blob/29f4645bf1244c9c3079053778be3e6ab1899fb1/problem-json/src/main/java/io/micronaut/problem/conf/MixInThrowableProblem.java : This essentially "adds" an annotation to another class dynamically depending on a config value. We can't modify the target class (ThrowableProblem) because it's in a library. I see a few options:
support mixins in other json mappers
only allow this feature for jackson
create a custom serializer for this type if there's ever a cross-format approach to doing this
wrap ThrowableProblem in another class that hides these fields

The last option seems to be the least intrusive, so I'll take a look if this is feasible.

edit: done, PR: https://github.com/micronaut-projects/micronaut-problem-json/pull/69

yawkat commented 2 years ago

[x] micronaut-rabbitmq: still on mn 3.0.3, can't use the json abstractions introduced in 3.1.

graemerocher commented 2 years ago

@yawkat have to upgrade the module at the same time

yawkat commented 2 years ago

micronaut-rabbitmq: https://github.com/micronaut-projects/micronaut-rabbitmq/pull/293
micronaut-mqtt: https://github.com/micronaut-projects/micronaut-mqtt/pull/108

yawkat commented 2 years ago

micronaut-nats: https://github.com/micronaut-projects/micronaut-nats/pull/192

yawkat commented 2 years ago

micronaut-liquibase: https://github.com/micronaut-projects/micronaut-liquibase/pull/205

yawkat commented 2 years ago

micronaut-pulsar: https://github.com/micronaut-projects/micronaut-pulsar/pull/141

yawkat commented 2 years ago

micronaut-jms: https://github.com/micronaut-projects/micronaut-jms/pull/188

yawkat commented 2 years ago

micronaut-sql: https://github.com/micronaut-projects/micronaut-sql/pull/516

yawkat commented 2 years ago

micronaut-graphql: https://github.com/micronaut-projects/micronaut-graphql/pull/223

yawkat commented 2 years ago

micronaut-kafka: https://github.com/micronaut-projects/micronaut-kafka/pull/444

yawkat commented 2 years ago

micronaut-security: https://github.com/micronaut-projects/micronaut-security/pull/889

sdelamo commented 2 years ago

Problem has this bug https://github.com/micronaut-projects/micronaut-problem-json/issues/94

graemerocher commented 2 years ago

Doesn’t seem like a bug