search

micronaut-projects / micronaut-starter

Generates Micronaut applications
Apache License 2.0
205 stars 93 forks source link

Fix Maven/Groovy builds with zipkin and jaeger #2483

Closed timyates closed 1 month ago

timyates commented 1 month ago

We had an api dependency on micronaut-core-processor which meant it was ending up on the runtime classpath.

This was fixed here

https://github.com/micronaut-projects/micronaut-tracing/issues/553#event-12652214705

However for Maven and Groovy this causes a failure as it no longer ends up getting pulled onto the provided configuration.

Once this fix is released, we can remove the skips from the jaeger and zipkin guides here:

https://github.com/micronaut-projects/micronaut-guides/pull/1459/commits/798040a62c910ec8ac19852e89c68f79aa4c12f0#diff-429b78dd62241a22ac3b663ca2d045441a9326121c3b6bbf19f5859d94c2e3d8

sdelamo commented 1 month ago

@timyates create a draft PR in guides reverting the skips

timyates commented 1 month ago

https://github.com/micronaut-projects/micronaut-guides/pull/1461