search

micronaut-projects / static-website

The Micronaut website
Apache License 2.0
4 stars 18 forks source link

Maven plugin blog post #196

Closed alvarosanchez closed 3 years ago

alvarosanchez commented 3 years ago

The background image is reused from other post:

Also, I don't get the $ character to render correctly, and I didn't find a way to escape it:

JasonTypesCodes commented 3 years ago

It looks like the $ is getting double encoded: $

JasonTypesCodes commented 3 years ago

This might be a bug in the md parser we are using... I'll check into that a bit

alvarosanchez commented 3 years ago

Also having syntax highlighting would be a great addition

JasonTypesCodes commented 3 years ago

This is the problem line: https://github.com/micronaut-projects/static-website/blob/a3eb1ea18015365d07558eefd855940399e374f2/buildSrc/src/main/groovy/io/micronaut/gradle/RenderSiteTask.groovy#L274

Taking that out makes the dollar signs render correctly, however they are not escaped. @sdelamo was that added because the MD parser isn't escaping those characters, or is there something else that requires that line?

JasonTypesCodes commented 3 years ago

@alvarosanchez I moved the dollar sign escaping to happen after the md has been parsed instead of before. I believe that fixes it