micropackage / block-loader

Automatic WordPress Gutenberg block loader based on template files
GNU General Public License v3.0
24 stars 5 forks source link

Publish latest dependency update #2

Open davidwebca opened 3 years ago

davidwebca commented 3 years ago

Hi! Sorry to bother you, but it seems like the latest addition of Micropackage\Filesystem\Filesystem slipped into the code, but not in the composer.json file (maybe a publishing issue with composer?) so that when I installed the package, it didn't install Micropackage\Filesystem\Filesystem. To fix the issue, I had to install it manually even though it seems like you added it as a dependency lately.

Here's the composer.json file of the package that got installed on my end

{
    "name": "micropackage/block-loader",
    "version": "1.0.3",
    "description": "Block Loader - automatic Gutenberg blocks from template files.",
    "license": "GPL-3.0-or-later",
    "authors": [
        {
            "name": "Jakub Mikita",
            "email": "jakub@bracketspace.com"
        },
    {
      "name": "Wojtek Szałkiewicz",
      "email": "wojtek@szalkiewicz.pl"
    }
    ],
    "scripts": {
        "phpcs": "phpcs",
        "phpcbf": "phpcbf"
    },
    "require": {
        "php": ">=5.6",
        "micropackage/singleton": "^1.1",
        "micropackage/dochooks": "^1.0"
    },
    "require-dev": {
        "dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
        "phpcompatibility/php-compatibility": "^9.1",
        "wp-coding-standards/wpcs": "^2.0"
    },
    "autoload": {
        "psr-4" : {
            "Micropackage\\BlockLoader\\" : "src"
        }
    }
}

compared to what I can see in the repo right now

{
    "name": "micropackage/block-loader",
    "version": "1.0.3",
    "description": "Block Loader - automatic Gutenberg blocks from template files.",
    "license": "GPL-3.0-or-later",
    "authors": [
        {
            "name": "Jakub Mikita",
            "email": "jakub@bracketspace.com"
        },
    {
      "name": "Wojtek Szałkiewicz",
      "email": "wojtek@szalkiewicz.pl"
    }
    ],
    "scripts": {
        "phpcs": "phpcs",
        "phpcbf": "phpcbf"
    },
    "require": {
        "php": ">=5.6",
        "micropackage/singleton": "^1.1",
        "micropackage/dochooks": "^1.0",
        "micropackage/filesystem": "^1.1"
    },
    "require-dev": {
        "dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
        "phpcompatibility/php-compatibility": "^9.1",
        "wp-coding-standards/wpcs": "^2.0"
    },
    "autoload": {
        "psr-4" : {
            "Micropackage\\BlockLoader\\" : "src"
        }
    }
}
jakubmikita commented 3 years ago

Thanks for the notice @davidwebca !

There's indeed 4 commits not published. We'll be working on this package within a few days and will push the update

davidwebca commented 3 years ago

Hi again. Sorry to use this issue to start a conversation, but I was wondering what's your preferred / recommended way to enqueue assets through the dockblock. I'd like to avoid writing manually the full base url (/wp-content/themes/mytheme/blocks/assets/js/myblock.js). Somehow I expected the path to be prefixed automatically with get_template_directory_uri(). Is it something that's already supported but I'm just doing it wrong? If not, what do you think about adding it? 🤔

jakubmikita commented 3 years ago

@davidwebca that's a good idea, I created a separate issue.