search

microprofile / microprofile-opentracing

microprofile-opentracing
Apache License 2.0
55 stars 47 forks source link

Context propagation in mp-fault-tolerance #108

Open pavolloffay opened 6 years ago

pavolloffay commented 6 years ago

Some methods in fault-tolerance are executed on a different thread which breaks context. Namely, methods annotated with @Asynchronous 1 , but also @Timeout 2 (might not apply for all impls 3).

pavolloffay commented 6 years ago

https://github.com/michalszynkiewicz/thorntail-quotes/blob/master/src/main/java/io/thorntail/example/quotes/ads/AdRetriever.java#L39

Ladicek commented 4 years ago

I wonder which specification should "own" this, and I'd probably lean towards MP Fault Tolerance. On the other hand, if MP Context Propagation is ever added to MP Platform, then it's probably MP OpenTracing who "owns" tracing context propagation...

Ladicek commented 4 years ago

Also, it's really only @Asynchronous who mandates execution on different thread. The fact that @Timeout methods were also called on different threads with SmallRye Fault Tolerance 2.x was a bug and was fixed in SmallRye Fault Tolerance 4.x.