search

micropython / micropython-esp32

Old port of MicroPython to the ESP32 -- new port is at https://github.com/micropython/micropython
MIT License
673 stars 216 forks source link

esp32/ports/modnetwork.c: Implement network.WLAN.ifconfig('dhcp') #216

Closed MrSurly closed 6 years ago

MrSurly commented 6 years ago

To match other ports (CC3200)

Per discussion here: https://github.com/micropython/micropython-esp32/pull/187#issuecomment-340645940

nickzoic commented 6 years ago

Should really be (self->if_id == WIFI_IF_STA || self->if_id == ESP_IF_ETH) since this function runs both!

MrSurly commented 6 years ago

Yes, but that PR isn't merged yet.

On Oct 30, 2017 22:44, "Nick Moore" notifications@github.com wrote:

Should really be (self->if_id == WIFI_IF_STA || self->if_id == ESP_IF_ETH) since this function runs both!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/micropython/micropython-esp32/pull/216#issuecomment-340666374, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYHCM0jZvoJ4wbdzJb3ro2EtFMho_vCks5sxrPBgaJpZM4QMMfy .

nickzoic commented 6 years ago

oooooooooooh wait for it ... yes it is :-) #187

MrSurly commented 6 years ago

Updated for wired LAN, squashed, pushed.

MrSurly commented 6 years ago

Huh, looking at this, looks like I have a whole bunch of unrelated stuff in this commit.

dpgeorge commented 6 years ago

Sorry I missed this, it looks like it's still relevant (the ifconfig("dhcp") part). @MrSurly should I pull this dhcp change into upstream master?

MrSurly commented 6 years ago

@dpgeorge Looks like you're right. Unfortunately, I had to ship my ethernet-enabled ESP32 unit to a client. I can certainly order a new PHY and test, but it might be a while. @nickzoic Do you have hardware?

nickzoic commented 6 years ago

Yes, yes I do, somewhere around here, a modified Waveshare LAN8720 board wired to a DevKitC. If you want to update the branch to only have the bits you think it should have, I can re-test.

Update: found it! It's even still plugged together, so just let me know when you're ready.

MrSurly commented 6 years ago

I'm going to be on holiday until the 25th, so probably after that.

MrSurly commented 6 years ago

Working on this today.

MrSurly commented 6 years ago

Closing -- will make new PR in main repo.