Moduhashlib improvements

micropython / micropython-esp32

Old port of MicroPython to the ESP32 -- new port is at https://github.com/micropython/micropython

MIT License

669 stars 216 forks source link

Moduhashlib improvements #220

Closed danieledapo closed 6 years ago

danieledapo commented 6 years ago

add digest_size and block_size constants;
add implementation of hexdigest

danieledapo commented 6 years ago

@dpgeorge @nickzoic are you interested in merging these changes? Is there anything wrong with the code?

nickzoic commented 6 years ago

I think we should, yes, but like #199 I think we should make it apply across all ports.

dpgeorge commented 6 years ago

hexdigest is not really needed. One can do the same thing using binascii.hexlify(sha.digest()). That's compatible with normal CPython and doesn't require adding a lot of extra C code.