search

micropython / micropython-esp32

Old port of MicroPython to the ESP32 -- new port is at https://github.com/micropython/micropython
MIT License
673 stars 217 forks source link

Updated to latest IDF #89

Closed MrSurly closed 7 years ago

MrSurly commented 7 years ago

Not entirely sure CONFIG_ESP32_XTAL_FREQ_AUTO needs to be 1 or y

vandys commented 7 years ago

I'm pretty sure those are booleans from the config file, the "y" is for purposes of the config UI. 1 would be a better bet for both bools in your changes.

MrSurly commented 7 years ago

I'm pretty sure those are booleans from the config file, the "y" is for purposes of the config UI. 1 would be a better bet for both bools in your changes.

Done.

MrSurly commented 7 years ago

The esp32 port is still beta so as long as things work then it's ok. I assume you checked that wifi and your BT stuff works.

The whole point was to update the IDF to resolve espressif/esp-idf#520, because I kept getting hammered with crashes while testing BT.

Let me test the WiFi thoroughly tomorrow (actually at home -- don't have any ESP32 here), but I was playing around with WiFi today, and it seemed OK.

I'll post results here tomorrow.

MrSurly commented 7 years ago

... and your BT stuff works.

Speaking of which, I have a new branch (BT implementation) that is rebased off of this branch (IDF update), so if this PR is merged, then I'll have to retract #86 (BT implementation on old IDF), and resubmit, since the differences are substantial enough that a simple rebase won't suffice.

dpgeorge commented 7 years ago

Thanks, this was squashed and merged in d7049f3850473e7d641e05e90ffe3282da7f8c34. Follow up commits were made in e2761615e0c86f49819a836d1c06976c90792787 and 48b5f4f783621152549ce712b7612b91bbbd10e1