tarfile-write: fix TarInfo mode in add() method. Set permissions to 644 instead of 000 (fixes #797)

micropython / micropython-lib

Core Python libraries ported to MicroPython

Other

2.3k stars 981 forks source link

tarfile-write: fix TarInfo mode in add() method. Set permissions to 644 instead of 000 (fixes #797) #798

Closed ubidefeo closed 5 months ago

ubidefeo commented 5 months ago

This change fixes issue #797 which I opened a bit earlier.

I'm not sure how to go about this PR because the suggested change doesn't require a lot of the code linting and other requests from the contributing guidelines, but maybe I'm missing something. I didn't even clone the repository but did everything in GitHub to avoid VS Code applying weirdness to the file format, hope it works out.

thanks ubi

ubidefeo commented 5 months ago

set as draft as I investigate further issues with TarInfo returing False for isdir()

ubidefeo commented 5 months ago

I'll open a new PR with a properly named branch from my fork and better compliance with the contribution guidelines :)