microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
35 stars 26 forks source link

Typos in experiment control fail with no error message. #342

Closed iandobbie closed 6 years ago

iandobbie commented 6 years ago

If you for instance have a z step size of 0.0.5 (as Maria just did) this generates a very opaque exception. We should sanity check this input before trying to run an experiment.

mickp commented 6 years ago

Fixed for common experiment parameters in single site dialog window. Can use same validators elsewhere, but probably need to add a flag that allows blank entries for things like exposure times, where not every exposure time / light pair needs an entry.

mickp commented 6 years ago

Added to more parameters in #382. Some controls have duplicate names, because of the way they are created, so added colour to highlight which is the problem. Validation is now applied to all common paramters for single-site experiments, namely:

I have not yet applied it to parameters that are specific to:

mickp commented 6 years ago

384 applies float and int validators to more experiments. I think all the parameters are covered now, except those that expect a comma-separated list of floats.

mickp commented 6 years ago

Comma-separated lists validated as of b6e056f10047108676a666897400c6f3b1c1c575.