search

microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
35 stars 26 forks source link

abort button should offer to remove data files #403

Open carandraug opened 5 years ago

carandraug commented 5 years ago

While working on improving the experiment window, we found the following use case:

  1. run 'update' filename on the experiment dialog to insert current time
  2. run experiment
  3. abort experiment
  4. change settings
  5. run experiment again without updating filename to new time because this allows to overwrite previous aborted experiment which we don't want to keep

This is not the right place for this action, if the data is not to be kept, then it should remove as part of the abort. So aborting an experiment should popup a dialog asking whether the data files should also be removed and list the files that will be removed if the user presses 'delete' (not ok, this is a potential dangerous move and we want to use a word that will cause user to pay attention).

This change will also mean that we can remove the 'update' button from the filename dialog and use a template system which will be more flexible.

mickp commented 5 years ago

Just to note, we considered leaving the user to clear up unwanted data from their data folder, but this introduces a risk of losing useful data.

Probably, the default action should be not to delete, so if the user just hits space or return, their data is not lost, but we could add a hotkey (e.g. 'd') so that deletion can be confirmed with the minimum of keypresses.

On Mon, 1 Oct 2018 at 14:13, Carnë Draug notifications@github.com wrote:

While working on improving the experiment window, we found the following use case:

  1. run 'update' filename on the experiment dialog to insert current time
  2. run experiment
  3. abort experiment
  4. change settings
  5. run experiment again without updating filename to new time because this allows to overwrite previous aborted experiment which we don't want to keep

This is not the right place for this action, if the data is not to be kept, then it should remove as part of the abort. So aborting an experiment should popup a dialog asking whether the data files should also be removed and list the files that will be removed if the user presses 'delete' (not ok, this is a potential dangerous move and we want to use a word that will cause user to pay attention).

This change will also mean that we can remove the 'update' button from the filename dialog and use a template system which will be more flexible.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MicronOxford/cockpit/issues/403, or mute the thread https://github.com/notifications/unsubscribe-auth/AE5prwTEdOhzg3FLJNMWPqfvJzQ6Fh7kks5ughTmgaJpZM4XCCY0 .

--

Mick Phillips