search

microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
35 stars 26 forks source link

microscopeDeformableMirror assumes a square image for wavefront sensor. #679

Closed iandobbie closed 3 years ago

iandobbie commented 3 years ago

The microscopeDeformabelMirror composite device including a DM and an intereferometer for wavefront sensing assumes that the camera on the interferometer is square.

Can be worked around by setting a square ROI on the camera

carandraug commented 3 years ago

None of of the deformable mirror stuff has been merged yet. Adding @NickHallONBI which I guess is the author of code one some of his branches.

NickHallPhysics commented 3 years ago

This is a Microscope-AOtools issue, not a cockpit issue. I will add it to the Microscope-AOtools project

carandraug commented 3 years ago

This is a link to the issue opened MicronOxford/microscope-aotools#5 (by the way, Nick, it's possible to transfer issues between repositories, see the "Transfer issue" button at the bottom of the right side bar).