search

microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
37 stars 27 forks source link

Windows error caused when hitting the positive/negative height limit #832

Closed thomasmfish closed 1 year ago

thomasmfish commented 2 years ago

It seems the error is caused while handling the actual warning/error. I'll get a screenshot later but someone is using the microscope at the moment

iandobbie commented 2 years ago

I added some code relatively recently to display a modal dialog when any axis limit is reached. Maybe this is at fault.

thomasmfish commented 2 years ago

That's my guess too. I haven't had a chance to look into it further yet but it's not a huge problem as it gets captured by Cockpit

From: Ian Dobbie @.> Sent: Thursday, November 10, 2022 4:09:28 PM To: MicronOxford/cockpit @.> Cc: Fish, Thomas (DLSLtd,RAL,LSCI) @.>; Author @.> Subject: Re: [MicronOxford/cockpit] Windows error caused when hitting the positive/negative height limit (Issue #832)

I added some code relatively recently to display a modal dialog when any axis limit is reached. Maybe this is at fault.

— Reply to this email directly, view it on GitHubhttps://github.com/MicronOxford/cockpit/issues/832#issuecomment-1310531545, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AL6IKW376PB3PJOBMHWXLJ3WHUM3RANCNFSM6AAAAAAR4V3B7M. You are receiving this because you authored the thread.Message ID: @.***>

-- This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail. Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message. Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

thomasmfish commented 2 years ago

I can't seem to replicate this today, so it may be a Windows problem. It can probably be handled better though, as the message that shows up looks very serious and scary compared to a "you've hit the limit!" message!

thomasmfish commented 1 year ago

Closing as I think this was fixed with some previous updates