search

microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
35 stars 26 forks source link

Unassigned variables in PicoMotorDevice #863

Closed thomasmfish closed 1 year ago

thomasmfish commented 1 year ago

Unassigned in homeMotors: endpositon oldposition

Not an issue for me, just thought I should report it

iandobbie commented 1 year ago

As far as I know the only system actually using this device was the original Oxford CryoSTORM system. This was dismantled some time ago and I certainly don't have access to the hardware so I'm a little reluctant to fix them.

Anyway the device should be moved into microscope, I wonder if this is the moment to delete it from cockpit maybe leaving it in a legacy device branch so we don't accidentally loose the code if we need it again in future?

iandobbie commented 1 year ago

Just looked and the fix is pretty obvious. The oldposition should be origPosition and the assignment for endposition had a typo in the name. No method to test this so just checking it in. Commit d92b79b2