search

microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
37 stars 27 forks source link

Incorrect server entries in depot config fail silently. #872

Closed iandobbie closed 1 year ago

iandobbie commented 1 year ago

I had a typo in my server ip address and my cockpit config appeared to work fine except all data devices (cameras, value loggers etc...) failed to return any data totally silently.

Can we either check the server creation succeeds, check pyro connections back to it work, or maybe both.

carandraug commented 1 year ago

There was an exception raise by Pyro but because we're using futures and not checking the return value from finalizeInitialization, these were never raised on the main thread. This is now fixed (I've added a check for exceptions in all devices and handlers) in bd688533f4129b8. Closing as fixed.