search

microscope-cockpit / cockpit

Cockpit is a microscope graphical user interface. It is a flexible and easy to extend platform aimed at life scientists using bespoke microscopes.
https://microscope-cockpit.org
GNU General Public License v3.0
37 stars 27 forks source link

UI to set individual device settings #901

Open carandraug opened 3 months ago

carandraug commented 3 months ago

Currently, the only devices that expose the settings dict in cockpit are cameras through their settings button on the main window:

Screenshot from 2024-08-21 13-41-57

But all Python-Microscope devices have a settings dict. Would be nice to expose that but not all devices have space for them on the main window. I'm thinking the simplest thing would be to add a menu bar for devices that would open those as separate windows. (requested by @LauraA-Octopus on image.sc https://forum.image.sc/t/adding-settings-on-stage-controller/100713)

carandraug commented 3 months ago

I have implemented a minimal solution on my 901-devices-menu branch:

Screenshot from 2024-08-21 13-47-12

This does not filter devices that are not Python-Microscope devices. We probably could group them by type somehow. And the "setings" button beneath the camera does some extra things that I'm not sure what they are for. But this is a start for people to comment and maybe use as hint to implement better.

iandobbie commented 3 months ago

Seems like a good idea.

LauraA-Octopus commented 3 months ago

This seems indeed a good idea, I can try it in the lab probably this Friday. Hopefully this will solve the issue, otherwise I will have to write a custom class for the AMC in cockpit, which I'd rather avoid since you are trying to be not device specific

juliomateoslangerak commented 3 months ago

Good idea. I might consider renaming the menu to Settings or Device settings though.