Closed starcalibre closed 9 years ago
Okely! Done! Essentially I've asked you to remove a couple of anon functions but otherwise pretty good! Not really that much code changed for a hugely different functionality! =)
Incidentally, for all the bits where I say "great comment, can you document it somewhere", but there's no obvious place in-line in the code for it, how about adding a "notes" directory where you include all this in text files? I just saw that we have that for microscopium and I think it's a good idea, to help new coders get up to speed on our (your) conventions...!
Exciting!
I've marked this WIP because there's still a couple of bits and pieces to be done, such as updating the docstrings to relfect the changes I've made. However the functionality is there if we want to try putting the branch online.
Other updates in this PR include: