microservices-demo / front-end

Front-end application for ALL the microservices
Apache License 2.0
79 stars 2.25k forks source link

Shippable pipeline broken #65

Open ToSa27 opened 7 years ago

ToSa27 commented 7 years ago

The tag name change to "master-<8 char commit SHA>" introduced in Commit 55ae946 works fine and the image with the proper tag is pushed to the repository but the shippable pipeline doesn't pick it up properly. The deploy step (to test) fails when executing /home/shippable/micro/nod/stepExec/managed/deploy/run.sh and looking at the failed ECS tasks the error message is like this: "Status reason CannotPullContainerError: Error: image front-end:master.2 not found". With the new tagging "master.2" does not exist anymore and instead it should use "master-<8 char commit SHA>".

ToSa27 commented 7 years ago

I made it work by switching back from "TRAVIS_TAG" to "IMAGE_TAG" at the bottom of push.sh. That's obviously not what is intended but fixes the pipeline for now.

There are two more minor issues with the documentation for the ecs-weave-shippable deployment (here):

  1. the step to commit the changes for the microservice-demo is missing (after changing the shippable.resource.yml file)

  2. scope is not running automatically. I had to ssh in and start it to make it available on port 4040.