microservices-demo / user

The users microservice.
http://microservices-demo.github.io/
Apache License 2.0
91 stars 617 forks source link

user service fails to build after updated github.com/go-kit/kit packages #42

Closed ghost closed 7 years ago

ghost commented 7 years ago

If you clear out your local go packages pointed to by $GOPATH, and pull in the absolute latest packages from https://github.com/go-kit/kit. The user service will fail to build.

There are two key things that have changed in the go-kit package:

  1. func NewServer located in github.com/go-kit/kit/transport/http/server.go has changed. A context argument has been removed. This causes microservices-demo/user/api/transport.go to fail to build. The fix is to remove the extra context argument that is now not needed. Here is the go-git commit where this argument is removed: https://github.com/go-kit/kit/commit/5b4da74163069a1b1763c6a580eba617cd8880d1#diff-4ab7a08a19cb59a477109d74275a617e

  2. In microservices-demo/user/main.go. In lines 53,54 and 62. "NewContext" is no longer needed. This has been removed from go-kit. Here is the go-kit commit where this change is made: https://github.com/go-kit/kit/commit/ee7b7bb66adf2f42a65fdcea881bcf82f6fc165b#diff-dc1d71bbb5c4d2a5e936db79ef10c19f