search

microservices-demo / user

The users microservice.
http://microservices-demo.github.io/
Apache License 2.0
91 stars 617 forks source link

Apitest #6

Closed jasonrichardsmith closed 8 years ago

jasonrichardsmith commented 8 years ago

Addresses issue https://github.com/microservices-demo/user/issues/4

Added new Makefile rule Fixed missing Card links Added hooks.js for post data Added defaults for IDs Added APITest to docker test so run on travis.

Test results https://travis-ci.org/microservices-demo/user/builds/154083600#L721

@alex-glv @idcrosby @philwinder @mongrelion

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.03%) to 21.335% when pulling 55fdc90536a382b911943ad7f469dd9cf9e2fcc5 on apitest into 986a70e9689f9f0fe8f0edfc79470646fe5e44bf on master.

sashkachan commented 8 years ago

Could you add "--rm" when starting user-dev and myweaveworkstestuserdb? It's impossible to rerun the tests because these stay running occupying the containers names.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.03%) to 21.335% when pulling fd586411b12c35cbf96af188be682053c54fffda on apitest into 986a70e9689f9f0fe8f0edfc79470646fe5e44bf on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.03%) to 21.335% when pulling b67842df82acc62621f26c9a00a32eab14cceafb on apitest into 986a70e9689f9f0fe8f0edfc79470646fe5e44bf on master.

sashkachan commented 8 years ago

The PR looks good to me, fix the coverage, though. Improve by at least 0.03%.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.9%) to 22.251% when pulling 16e9e30aec62c85174d4562ec837b9dc47e8e3a5 on apitest into 986a70e9689f9f0fe8f0edfc79470646fe5e44bf on master.