microservices-demo / user

The users microservice.
http://microservices-demo.github.io/
Apache License 2.0
91 stars 617 forks source link

Avoid granting Linux capabilities #62

Closed shiresky closed 3 years ago

shiresky commented 4 years ago

My task was to run your Helm chart on K8s cluster with restrictive pod security policy. The worst problem I encountered was that you grant Linux capabilities in order to bind 80 port inside of container. As a result I was not able to run these images in any way without rebuilding them reverting this operation. That's why I propose you to use other port inside of containers and map it externally to 80 during running a container.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 23.465% when pulling 21ef8b2404bd29d4de14c1443e891a88d09d32e3 on nokia:nokia into af5e0a7e7210b47bfccaa3f53915e3c780fe7e70 on microservices-demo:master.

CsatariGergely commented 4 years ago

@elieser1101 can you please review this?

CsatariGergely commented 3 years ago

@Ottovsky can you please review this pr also?

Ottovsky commented 3 years ago

@elieser1101 @darren-reddick could you have a look?