search

microservices-demo / user

The users microservice.
http://microservices-demo.github.io/
Apache License 2.0
91 stars 617 forks source link

Fixplurals #8

Closed jasonrichardsmith closed 8 years ago

jasonrichardsmith commented 8 years ago

This changes the json tags from plurals to singular for the arrays of customers, addresses, and cards.

This also add links for cards and addresses to the top level links object of the customer.

@philwinder @idcrosby @alex-glv @mongrelion

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.251% when pulling b21f5ed3724e3a37e1941df3f6cf2ed2dbe50307 on fixplurals into bc8972a1c0b4a4fc0c76db81e691e66c44cd0f0d on master.

mongrelion commented 8 years ago

@jasonrichardsmith I think I'm missing some context here because I don't get why, if we're returning a list of things, the key in the JSON is in singular instead of in plural (?)

jasonrichardsmith commented 8 years ago

@mongrelion The singular comes from the accounts apispec.