Closed gnott closed 5 years ago
bib6 please remove the
forthcoming tag
This is published now, but was not when published, so we should not update: Vol. 63, No. 1/2 (January - June 2007), pp. 11-31
@gnott Please do fix mentioned in https://github.com/microsimulation/ijm/issues/5
<ref id="bib25">
<element-citation publication-type="confproc">
<person-group person-group-type="author">
<name>
<surname>Kelly</surname>
<given-names>S</given-names>
</name>
</person-group>
<year iso-8601-date="2007a">2007a</year>
<chapter-title>DYNAMOD</chapter-title>
<person-group person-group-type="editor">
<name>
<surname>Gupta</surname>
<given-names>A</given-names>
</name>
<name>
<surname>Harding</surname>
<given-names>A</given-names>
</name>
</person-group>
<source>Modelling our Future: Population Ageing, Health and Aged Care</source>
<conf-name>International Symposia in Economics</conf-name>
<volume>16</volume>
<conf-loc>North-Holland, Amsterdam</conf-loc>
<fpage>439</fpage>
<lpage>442</lpage>
</element-citation>
</ref>
@Vijayarajmurugesan
Please fix this reference:
<year iso-8601-date="2007a">2007a</year>
Should be:
<year iso-8601-date="2007">2007a</year>
Please update your code so @iso-8601-date
never have letters in there. This is not a valid iso date.
And:
<chapter-title>DYNAMOD</chapter-title>
Should be:
<title>Model 2: DYNAMOD</title>
@matteorichiardi FYI
If you could please check that all <person-group>
tags in the references are given a person-group-type
attribute, otherwise I cannot convert the XML to JSON.
@Melissa37, I think the
<source>Modelling our Future: Population Ageing, Health and Aged Care</source>
could be
<article-title>Modelling our Future: Population Ageing, Health and Aged Care</article-title>
as is specified in the eLife kitchen sink XML. Otherwise, the <source>
tag does not convert to the JSON attribute required for validation.
If you do not like <article-title>
in the XML, then I will need to change our XML parser to pick up the <source>
tag value.
@Vijayarajmurugesan
Please convert:
<source>Modelling our Future: Population Ageing, Health and Aged Care</source>
To:
<article-title>Modelling our Future: Population Ageing, Health and Aged Care</article-title>
@Melissa37 Fixed the above issue. Please find the below link for updated files: https://exeterpremedia.exavault.com/share/view/1i5dm-9s6a5s81
Thanks!
I am reviewing the resupplied file.
I noticed bib25
still has <chapter-title>DYNAMOD</chapter-title>
, however I think Melissa specified it should be changed to <title>Model 2: DYNAMOD</title>
above.
There is a validation issue with bib27
, a report reference, that does not produce a required title in the JSON output. I think this reference could do with a <source>
value to conform to report type references.
@Melissa37 if you could please confirm these observations?
@Vijayarajmurugesan please resupply. M
@Melissa37: I have checked the resupply package, the 1st point is already fixed in the XML. Now am fixed the 2nd point and uploaded the package to the below path: https://exeterpremedia.exavault.com/share/view/1i5dm-9s6a5s81 Regards, Vijay
The validation issue I encountered on bib27
is resolved with the latest resupply, thanks Vijay.
I'm still seeing <chapter-title>Model 2: DYNAMOD</chapter-title>
on bib25
, unless I'm looking in the wrong place or maybe the earlier instructions to change it are obsolete now? I would like to allow @Melissa37 to check it before this issue to closed.
@gnott @Melissa37: I have checked the resupplied package, In the references, we retained the chapter-title tag only. I change chapter-title to the title, am getting DTD validation error, within element citation title tag has not allowed. Could you please check and advise. Thanks, Vijay
The article does not cause any errors, and when the reference is displayed on the demo, the chapter title is not shown. For my purposes the XML tagging has little or no impact at this time. I think @Melissa37 can add additional comments about the particular tag and whether it has future implications.
Here's the web view of it right now:
This is one for @thewilkybarkid to consider for Libero.
The eLife references are too strict for most publishers so we'll leave as is for this.
Thanks! M
Two edits would be good for the
ijm-00005.xml
file please:bib6
please remove the<year>forthcoming</year>
tagbib25
it would be helpful if you could add a<article-title>
tag with a value for the conference proceeding, which would allow it to be valid against the current schemaIf you could please review @Melissa37 and comment or assign for implementation - thanks!