search

microsimulation / ijm-xml

XML files for the International Journal of Microsimulation
MIT License
0 stars 0 forks source link

QC on Continuum instance to check for other potential "eLife-ness" of the website #26

Closed Melissa37 closed 5 years ago

Melissa37 commented 5 years ago

@BlueReZZ @giorgiosironi

I pushed some IJMicrosim data to this branch on the demo project: https://github.com/microsimulation/demo/tree/volume1 It includes some tweaks to display not-so-valid reference data.

Article 00005 is not valid yet, the dates on these first seven articles are not correct, and these will be changed in a subsequent supply from ExeterPremedia.

If you'd like to try getting the volume 1 branch running for a preview, please do! I'm sure Melissa would be interested to see it. It might be helpful to see if the volume 1 branch could be made visible on the Internet to allow others to review the site without learning how to run Docker.

It could be gathering feedback from eLife first might be an idea, for example where article say "CITE AS: eLife 2007;1:n/a" at the top (the n/a being a necessary elocation-id which is not in the XML), the meta tags has some eLife content as well. I also noticed the copyright dates are 2012 for 2007 articles, and I think those are tied into eLife's first year of publication. There must be others to find too, before showing it to IJM? Or leave it to them to review? Up to you!

Please let me know if I can help in the review process somehow. My next steps will be to further automate the content conversion I have going on, and convert more articles.

Todo

Melissa37 commented 5 years ago

@gnott please can you add the other things you've noticed to this ticket

gnott commented 5 years ago

Some eLife examples I've noticed:

  1. CITE AS at the top of an article (as mentioned above). E.g. circled in red below

image

  1. Title tag, e.g.

<title>Editorial | eLife</title>

(should be fairly simple, but if I could get exact wording please?)

  1. Meta tags

A portion of the meta tags with some eLife-like content:


<meta name="dc.publisher" content="eLife Sciences Publications Limited">
...
<meta property="og:site_name" content="eLife">
<meta property="og:url" content="http://localhost:8080/articles/00001">
...
<meta name="twitter:site" content="@eLife">
  1. Hidden page content

There are some eLife words mentioned in some hidden elements on the page. I can point these out, if they matter, they probably won't matter for the demo?

E.g.

<span class="visuallyhidden" >eLife home page</span>

  1. Copyright year

The copyright year seems to be generated based on the volume value and the year eLife first published. Screenshot:

image

Presumably I should find this and change it.

Melissa37 commented 5 years ago

@matteorichiardi can you let us know whether we should use International Journal of Microsimulation or IJM in the Cite as line?

Thanks!

Melissa37 commented 5 years ago

Meta tags hidden page content

@matteorichiardi can you confirm that for the purposes of the demo this is OK to leave with eLife name and not IJM?

Melissa37 commented 5 years ago

@gnott

Copyright year

Yes please!

matteorichiardi commented 5 years ago

International Journal of Microsimulation

thanks. Matteo

On Wed, 8 May 2019 at 10:04, Melissa Harrison notifications@github.com wrote:

@matteorichiardi https://github.com/matteorichiardi can you let us know whether we should use International Journal of Microsimulation or IJM in the Cite as line?

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microsimulation/ijm-xml/issues/26#issuecomment-490409380, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOK4ODGZOG7FAULUVJEJKDPUKJTDANCNFSM4HLG2U2Q .

gnott commented 5 years ago

Copyright year fixed in https://github.com/microsimulation/demo/pull/8.

gnott commented 5 years ago

Going with CITE AS: IJM 2007;1:n/a - with a simple string replacement.

gnott commented 5 years ago

Changing <title> tag in https://github.com/microsimulation/demo/blob/master/journal/app/Resources/views/base.html.twig

gnott commented 5 years ago

Committing eLife-ness changes in https://github.com/microsimulation/demo/pull/9

This should cover all the basics now, if someone would please confirm whether we should leave this open to collect additional feedback?

Melissa37 commented 5 years ago

@gnott I think we can close this ticket and open new one(s) as we find further issues.

Thanks! M