microsimulation / ijm-xml

XML files for the International Journal of Microsimulation
MIT License
0 stars 0 forks source link

ijm-00037.xml author institution #42

Closed gnott closed 5 years ago

gnott commented 5 years ago

Checking for validation of JSON output from file ijm-00037.xml does not succeed.

The error is concerning the author. I have tracked it down to the JSON author affiliation is missing a name attribute. This would come from the <aff> tag's <institution> tag.

One possible solution is to add a <institution> tag to the XML with a value.

An alternate solution is I need to add n/a to the JSON output for this value, when missing, and then change the web page to not display the n/a value.

@Melissa37 if you could please consider this issue and recommend a solution.

Melissa37 commented 5 years ago

@Vijayarajmurugesan This will require a resupply because country contains a postcode and not just the country

<aff id="aff1">
                    <label>1</label>
                    <addr-line>284 Albert Road, South Melbourne</addr-line>
                    <country>Australia 3205</country>
                </aff>
                    <label>1</label>
                    <addr-line>284 Albert Road, South Melbourne, 3205</addr-line>
                    <country>Australia</country>
                </aff>
Melissa37 commented 5 years ago

@gnott I think this is one that will have to not show up on the Continuum website. Other than wrong tagging requested for resupply above, this is a personal address and will be managed properly by Libero, but for Continuum won't work. We cannot invest time in getting it to work on a site it will never be live on.

Thanks!

@thewilkybarkid @matteorichiardi for info

Vijayarajmurugesan commented 5 years ago

@Melissa37 Fixed the issue and uploaded the package to an ftp site: https://exeterpremedia.exavault.com/share/view/1i5dm-9s6a5s81 Regards, Vijay

gnott commented 5 years ago

In the resupplied XML, I see <country>Australia 3205</country> still. Over to @Melissa37 for any additional clarification on the edits here. The JSON still remains invalid, and without an institution, it will not work on the demo site, I believe.

Melissa37 commented 5 years ago

For @Vijayarajmurugesan for resupply.

gnott commented 5 years ago

This article loads on the demo site, although the correct country value I expect is still something to be corrected.

Vijayarajmurugesan commented 5 years ago

@matteorichiardi @Melissa37 In this article have a no institution for the author. Please advise.

Melissa37 commented 5 years ago

I will close this issue - it shows on the demo site :-) That's good for now!