microsimulation / ijm-xml

XML files for the International Journal of Microsimulation
MIT License
0 stars 0 forks source link

ijm-00044.xml confproc references #44

Closed gnott closed 5 years ago

gnott commented 5 years ago

References of type confproc in XML file ijm-00044.xml when converted to JSON the resutl is not valid against the schema.

These references are:

bib7
bib8
bib13

One solution is to add an <article-title> tag to the references, which will populate the articleTitle attribute in the JSON file. Alternatively, one code fix (if <source> tag is preferred) is I need to change our XML parser to use that value as the articleTitle when <article-title> is not present.

Please note, there is a similar issue about references of type confproc in issue https://github.com/microsimulation/ijm-xml/issues/24

Melissa37 commented 5 years ago

@Vijayarajmurugesan

Bib7

<ref id="bib7">
                <element-citation publication-type="confproc">
                    <collab>Eurostat</collab>
                    <year iso-8601-date="2004">2004</year>
                    <source>Income in EU-SILC: Net-Gross-Net Conversion; Common Structure of the
                        Model; Model Description; and Application to ECHP Data for France, Italy and
                        Spain</source>
                    <conf-name>EU-SILC 133/04, Working Group on Statistics on Income and Living
                        Conditions (EU-SILC)</conf-name>
                    <conf-date>29&#x2013;30 March 2004</conf-date>
                    <conf-loc>Luxembourg</conf-loc>
                    <conf-sponsor>Eurostat</conf-sponsor>
                </element-citation>
            </ref>

Please change:

<source>Income in EU-SILC: Net-Gross-Net Conversion; Common Structure of the
                        Model; Model Description; and Application to ECHP Data for France, Italy and
                        Spain</source>

To:

<article-title>Income in EU-SILC: Net-Gross-Net Conversion; Common Structure of the
                        Model; Model Description; and Application to ECHP Data for France, Italy and
                        Spain</article-title>

Please add: <year iso-8601-date="2004">2004</year>

bib8

<ref id="bib8">
                <element-citation publication-type="confproc">
                    <person-group person-group-type="author">
                        <name>
                            <surname>Figari</surname>
                            <given-names>F</given-names>
                        </name>
                        <name>
                            <surname>Levy</surname>
                            <given-names>H</given-names>
                        </name>
                        <name>
                            <surname>Sutherland</surname>
                            <given-names>H</given-names>
                        </name>
                    </person-group>
                    <year iso-8601-date="2007">2007</year>
                    <chapter-title>Using the EU-SILC for policy simulation: prospects, some
                        limitations and some suggestions</chapter-title>
                    <person-group person-group-type="editor">
                        <name>
                            <surname>EUROSTAT</surname>
                        </name>
                    </person-group>
                    <role>Ed</role>
                    <conf-name>Comparative EU statistics on Income and Living Conditions: Issues and
                        Challenges &#x2013; Proceedings of the EU-SILC conference</conf-name>
                    <conf-loc>Helsinki</conf-loc>
                    <conf-date>6&#x2013;8 November 2006</conf-date>
                    <fpage>345</fpage>
                    <lpage>373</lpage>
                </element-citation>
            </ref>

Please change:

 <chapter-title>Using the EU-SILC for policy simulation: prospects, some
                        limitations and some suggestions</chapter-title>

To:

<article-title>Using the EU-SILC for policy simulation: prospects, some
                        limitations and some suggestions</article-title>

bib13

<ref id="bib13">
                <element-citation publication-type="confproc">
                    <person-group person-group-type="author">
                        <name>
                            <surname>Rodrigues</surname>
                            <given-names>C F</given-names>
                        </name>
                    </person-group>
                    <year iso-8601-date="2007">2007</year>
                    <chapter-title>Income in EU-SILC &#x2013; Net/Gross Techniques for Building and
                        Using EU-SILC Databases</chapter-title>
                    <source>Comparative EU Statistics on Income and Living Conditions: Issues and
                        Challenges</source>
                    <conf-name>Proceedings of the EU-SILC conference</conf-name>
                    <conf-loc>Helsinki</conf-loc>
                    <conf-date>6&#x2013;8 November 2006</conf-date>
                </element-citation>
            </ref>

Please change:

 <chapter-title>Income in EU-SILC &#x2013; Net/Gross Techniques for Building and
                        Using EU-SILC Databases</chapter-title>

To:

<article-title>Income in EU-SILC &#x2013; Net/Gross Techniques for Building and
                        Using EU-SILC Databases</article-title>
Melissa37 commented 5 years ago

@gnott I assume it's Ok to leave '29–30 March 2004' as it's semantically correct although we will not display it on Continuum - we should retain for Libero

gnott commented 5 years ago

@gnott I assume it's Ok to leave '29–30 March 2004' as it's semantically correct although we will not display it on Continuum - we should retain for Libero

<conf-date>29&#x2013;30 March 2004</conf-date> does not end up in the JSON or on the demo site and will not cause any issues 👍

Vijayarajmurugesan commented 5 years ago

@Melissa37 Fixed the issue and uploaded the package to an ftp site: https://exeterpremedia.exavault.com/share/view/1i5dm-9s6a5s81 Regards, Vijay

gnott commented 5 years ago

In terms of validation, the references identified here in the feedback for resupply are valid and improved.

There's another part causing a validation issue, in bib9:

<element-citation publication-type="reprot">

This will convert properly if this is "report" rather than "reprot". This may be clear enough for resupply without Melissa checking? Thanks Vijay!

Vijayarajmurugesan commented 5 years ago

@gnott Fixed the issue and uploaded the package to an ftp site: https://exeterpremedia.exavault.com/share/view/1jbyg-1kd0axsa Regards, Vijay

gnott commented 5 years ago

There are no errors in validating or showing this article on the demo site (I didn't look too carefully at the actual content). Thanks @Vijayarajmurugesan!