Open citations: Papers and Citeulike don't work

microsimulation / ijm-xml

XML files for the International Journal of Microsimulation

MIT License

0 stars 0 forks source link

Open citations: Papers and Citeulike don't work #62

Closed Melissa37 closed 5 years ago

Melissa37 commented 5 years ago

Nothing happens if you click on Papers Screenshot 2019-05-17 at 15 28 21

This is what happens for Citeulike: Screenshot 2019-05-17 at 15 29 29

BlueReZZ commented 5 years ago

The Libero MVP which IJM will use is only planned to have a single download button for the PDF so these should probably be removed/hidden otherwise users may expect the same on launch.

Melissa37 commented 5 years ago

Thanks @BlueReZZ - who can do this? Who should this be assigned to?

BlueReZZ commented 5 years ago

I can probably do it with some assistance from @giorgiosironi as it seems to be a case of removing some lines here:

https://github.com/microsimulation/demo/blob/6c060a9aa600ea420c86f39bc786483da4b7fb36/journal/src/ViewModel/Converter/ArticleDownloadLinksListConverter.php#L55

BlueReZZ commented 5 years ago

This has been done under PR https://github.com/microsimulation/demo/pull/11 and merged. Just waiting for @giorgiosironi to deploy it