search

microsimulation / ijm

A central place for general issues, documents, scripts and resources for the IJM
https://microsimulation.org/ijm/
MIT License
4 stars 1 forks source link

Convert IJM Issue 14(2) #135

Closed pbronka closed 2 years ago

pbronka commented 2 years ago

Hi @gnott, I'm opening this issue as we should have a new 14(2) Issue of the IJM ready for conversion soon. I will update this when Exeter deposits the files to the S3 bucket. Would you please be able to convert it to JSON for us? Thank you.

pbronka commented 2 years ago

Hi @gnott , the following articles have now been uploaded to the S3 bucket:

ijm-00233.zip | zip | November 30, 2021, 18:24:48 (UTC+00:00) | 50.2 KB | Standard   | ijm-00234.zip | zip | November 30, 2021, 18:24:48 (UTC+00:00) | 5.4 MB | Standard   | ijm-00235.zip | zip | November 30, 2021, 18:24:49 (UTC+00:00) | 13.1 MB | Standard   | ijm-00236.zip | zip | November 30, 2021, 18:24:56 (UTC+00:00) | 6.4 MB | Standard   | ijm-00237.zip | zip | November 30, 2021, 20:03:14 (UTC+00:00) | 7.8 MB | Standard

I checked the XMLs as much as I was able to - hopefully the conversion will run smoothly.
Thanks!

gnott commented 2 years ago

Thanks @pbronka, I converted these today and the results were very good except for one validation error.

In article 00237, the reference bib21 is specified in the XML as a "web" reference, but it does not include a uri. As a test I guessed it might be a "thesis", and in doing so the reference in the JSON ends up as type unknown and it allows the web page to display.

Could you please check the type of reference for bib21 and to see if it includes all the possible tags for the reference? When the one article is resupplied to the bucket I can convert it again and create a PR with the new article content.

Thanks!

pbronka commented 2 years ago

Thank you for attempting the conversion @gnott and sorry about the error in bib21. This has now been updated to "report" type, for which it should have all required fields, and resupplied to the S3 bucket. Could you please try again and let me know if we are able to convert this article now? Thank you

gnott commented 2 years ago

Thanks Patryk, it was successful and I'm creating a PR for the new article content.

pbronka commented 2 years ago

That's great news, thanks a lot Graham. Seems to be all good - closing this ticket then.

pbronka commented 2 years ago

Sorry, need to reopen. The articles don't display tags (e.g. https://microsimulation.pub/subjects/taxes-benefits) on the website (the categories in blue above article's title, visible e.g. here https://microsimulation.pub/collections/14-1/volume-14-1-spring-2021 but not in the newest issue https://microsimulation.pub/collections/14-2/volume-14-2-summer-2021). I'm not sure how the tags are recorded normally, are they missing in the XML?

Edit: It would appear that the whole section is missing from the XMLs, I will ask for a resupply...sorry about that.

-<subj-group subj-group-type="heading">

<subject>...</subject>

</subj-group>
gnott commented 2 years ago

I didn't notice those, good eyes! I agree, the XML as you have above looks to be missing from the article XML.

pbronka commented 2 years ago

The tags have now been added to the XMLs and articles resupplied to the S3 bucket. Would you mind seeing if they will be picked up now?

gnott commented 2 years ago

The resupplied packages look good, a new PR in https://github.com/microsimulation/ijm/pull/138 for review.

pbronka commented 2 years ago

Thank you very much