microsimulation / ijm

A central place for general issues, documents, scripts and resources for the IJM
https://microsimulation.org/ijm/
MIT License
4 stars 1 forks source link

Convert articles for IJM 16(1) #170

Closed pbronka closed 1 year ago

pbronka commented 1 year ago

Hi @gnott,

Could you please convert IJM 15(3) for us? Articles included in this issue are:

  | ijm-00272.zip | zip | March 16, 2023, 11:20:47 (UTC+00:00) | 76.7 KB | Standard   | ijm-00273.zip | zip | March 16, 2023, 11:20:53 (UTC+00:00) | 2.5 MB | Standard   | ijm-00274.zip | zip | March 16, 2023, 11:20:54 (UTC+00:00) | 4.3 MB | Standard   | ijm-00275.zip | zip | March 16, 2023, 11:20:55 (UTC+00:00) | 751.0 KB | Standard   | ijm-00276.zip | zip | March 16, 2023, 11:20:55 (UTC+00:00) | 395.9 KB | Standard   | ijm-00277.zip | zip | March 16, 2023, 11:20:48 (UTC+00:00) | 1.8 MB | Standard

Thank you!

pbronka commented 1 year ago

Sorry, please hold off for now - there are some issues that should be fixed by Exeter.

Edit: These should now be fixed.

gnott commented 1 year ago

Converting these uncovered only a couple validation errors, and the suggested fixes please:


ijm-00274.xml

The appendix output is not valid.

Suggested fix: to remove <sec id="s7"> from the <app> tag then the output is valid

ijm-00276.xml

Citation id bib52 output is not valid.

Suggested fix: If the <article-title> tag is changed to a <source> tag then the output becomes a valid report citation.


If you would please have these resupplied to the bucket @pbronka, assuming the suggested fixes are acceptable, thanks!

pbronka commented 1 year ago

Thank you, these have now been corrected and resupplied to the S3 bucket. Please note that there were also minor updates to ijm.00277 but hopefully these won't break anything.

gnott commented 1 year ago

Thanks for the new zip files. There are no validation errors now, and I'll open a PR with new content shortly.

The publication date in article 00277 is March 17, 2023 instead of April 30, 2023 though, this you can change in the XML, and in the JSON file in the PR, if you wish.

pbronka commented 1 year ago

Updated 00277 and merged, thank you.

gnott commented 1 year ago

Look good @pbronka I'm glad to see it all merged.