search

microsimulation / ijm

A central place for general issues, documents, scripts and resources for the IJM
https://microsimulation.org/ijm/
MIT License
3 stars 0 forks source link

Convert articles for IJM 16(2) #191

Closed pbronka closed 9 months ago

pbronka commented 9 months ago

Hi @gnott ,

Could you please convert the following articles for IJM Summer 2023 Issue 16(2) for us?

  | ijm-00278.zip | zip | September 28, 2023, 11:30:14 (UTC+01:00) | 1.7 MB | Standard   | ijm-00279.zip | zip | September 28, 2023, 11:30:06 (UTC+01:00) | 390.7 KB | Standard   | ijm-00280.zip | zip | September 28, 2023, 11:30:08 (UTC+01:00) | 640.7 KB | Standard   | ijm-00281.zip | zip | September 28, 2023, 11:30:14 (UTC+01:00) | 3.3 MB | Standard   | ijm-00282.zip | zip | September 28, 2023, 11:30:14 (UTC+01:00) | 956.8 KB | Standard   | ijm-00283.zip | zip | September 28, 2023, 11:30:12 (UTC+01:00) | 2.1 MB | Standard   | ijm-00284.zip | zip | September 28, 2023, 11:30:12 (UTC+01:00) | 529.7 KB | Standard

Thank you.

gnott commented 9 months ago

Hi @pbronka,

I convered and validated these to find two articles need modification in order to satisfy the data schema.

Article 00279,

<subj-group subj-group-type="display-channel">
<subject>Tributes</subject>
</subj-group>

unfortunately does not translate into one of the predefined type values,

['correction', 'editorial', 'feature', 'insight', 'research-advance', 'research-article', 'research-communication', 'retraction', 'registered-report', 'replication-study', 'review-article', 'scientific-correspondence', 'short-report', 'tools-resources']

It is easiest if you are able to use one of these types. Would Editorial be good enough? scientific-correspondence is configured to be Book Review on the IJM site

Article 00280, there are some references of type report which do not have a title in the JSON output. These could be fixed in the XML by changing the <article-title> tag to a <source> tag. The reference ids are bib2,bib15, and bib17.

If you would please consider how these two article XML files may be adjusted to satisify the schema it would be much appreciated, and if my suggestions are possible in your mind.

pbronka commented 9 months ago

Thank you for the suggestions @gnott. Both articles have now been updated. In Ijm.00279, 'tributes' has been change to 'feature' - I hope this is fine, but if not, 'editorial' is ok.

gnott commented 9 months ago

Thanks for sending these @pbronka.

There's a couple more changes I request for the XML of 00279, one I forgot to mention last time.

If you could please use Feature article, e.g.

<subj-group subj-group-type="display-channel">
<subject>Feature article</subject>
</subj-group>

I forgot to mention a pub-date was missing which is required for all the content to be extracted. if you could please add

<pub-date pub-type="collection">
<year>2023</year>
</pub-date>

I changed my copy of the XML in order to generate output, and I will not need to download a new copy unless you'd like me to confirm the changes.

The site code was not configured to render a feature template. i made some changes which causes it to display.

pbronka commented 9 months ago

Thank you @gnott. If it was possible to proceed on the basis of what's currently in the S3 bucket, that would be great, and I will ask for these changes to be made.

pbronka commented 9 months ago

Looks all good, thank you @gnott!