microsoft-search / pnp-modern-search

Home of PnP Modern Search solutions, helping you move from classic to modern SharePoint and beyond
https://microsoft-search.github.io/pnp-modern-search
Other
387 stars 340 forks source link

Org Chart in Persona Card showing disabled users #2507

Closed sympmarc closed 1 year ago

sympmarc commented 1 year ago

Version used Ex: 4.6.1

Describe the bug When displaying people using the People layout, we can choose to show the persona card on hover. I think there's a bug in that implementation, in that people who are disabled in AAD are showing up. This doesn't match the behavior of the Org Charts in Microsoft Search results.

To Reproduce Steps to reproduce the behavior:

To reproduce, you need to have user profiles with Manager values. Those user profiles must be disabled in AAD. If you search for the Manager in Microsoft Search and look at the Org Chart, you won't see the disabled user(s). If you search in the PnP Modern Search Web Parts and look at the Org Chart in the persona card, you will.

Expected behavior Consistency between the two Org Chart implementations

Screenshots NA

Desktop (please complete the following information):

Additional context We've tested this pretty thoroughly and believe it to be a bug.

wobba commented 1 year ago

I assume this is the mgt card? And if so their repo is https://github.com/microsoftgraph/microsoft-graph-toolkit/issues and you can close this issue 🙂

sympmarc commented 1 year ago

Not sure, as I'm just using this setting on the 2 of 4 property panel for the PnP Search Results Web Part. Wouldn't it be how the persona card is used in that implementation?

image

wobba commented 1 year ago

Correct, and we reuse the graph toolkit components and have no control over their API calls or logic. We just load the card with a UPN and things happen.

sympmarc commented 1 year ago

Ok, got it. I'll lodge a complaint over there.

sympmarc commented 1 year ago

Issue in MGT

sympmarc commented 1 year ago

The MGT team is putting a fix into the December release.

wobba commented 1 year ago

Appreciate the update.

wobba commented 1 year ago

Packages are now updated in the dev branch

sympmarc commented 1 year ago

Just out of curiosity, do you have a timeframe for the next release? I won't hold you to it. :)

wobba commented 1 year ago

Sometime in 2023 😁

Ami99049 commented 1 year ago

@wobba @sympmarc @stevebeauge Have you released the new version with the changes in Hover Card org Chart or is it still in development phase

kasperbolarsen commented 1 year ago

Please review this issue, as it will inform you that the Org Chart is a MGT component, and just used by this project.

Ami99049 commented 1 year ago

@kasperbolarsen I installed pnp version 4.8 and still Disabled users is visible in Hover Card Org Chart via Microsoft Search as Data source. Is there any way to exclude those users.

kasperbolarsen commented 1 year ago

Not in this project as we are just using the MGT component. You should log the issue with MGT.