microsoft-search / pnp-modern-search

Home of PnP Modern Search solutions, helping you move from classic to modern SharePoint and beyond
https://microsoft-search.github.io/pnp-modern-search
Other
386 stars 340 forks source link

pnp v4.9 mgt-person -> person-card on hover with rtl is displayed incorrectly ( left positioning ) #3158

Closed danial999 closed 1 month ago

danial999 commented 1 year ago

Version used Ex: 4.9

Describe the bug pnp v4.9 mgt-person -> person-card on hover with rtl is displayed incorrectly ( left positioning )

To Reproduce Detailed steps to reproduce the behavior: added pnp search resault webpart v4.9 use mgt-person with dir="rtl" and person-card="hover" in custom template when hover on person to see card , the card is displayed in far right of the screen

Expected behavior on hover person card should be displayed on relative position to the person image

Screenshots image Desktop (please complete the following information): chrome

wobba commented 1 year ago

We don't really control how the mgt components render or show. If you think we can/should fix this in this project any pointer would be useful.

danial999 commented 1 year ago

I tested the described behavior on Microsoft Graph Toolkit (v3.1.0) Playground (https://mgt.dev/?path=/story/components-mgt-person--person) and found that mgt renders hover cards correctly with rtl. /* test example :

*/ So I assume the fix should be in this project. the calculation of the style attributes on the "flyout" class are not correct when the mgt is used in this project. image

wobba commented 1 year ago

I'll try to update for the next verison.