microsoft-search / pnp-modern-search

Home of PnP Modern Search solutions, helping you move from classic to modern SharePoint and beyond
https://microsoft-search.github.io/pnp-modern-search
Other
379 stars 337 forks source link

Accessibility: Filter AND/OR Screen Reader Issue #3901

Open jn394 opened 1 month ago

jn394 commented 1 month ago

Version used 4

Describe the bug While having a screen reader on and using the keyboard to navigate. While inside the filter options AND/OR. The "AND" will read out "Radio Button 1 of 3" and if you navigate to the "OR" it will read out "Radio Button 3 of 3". For that description, there seems to be a second radio button that is hidden.

To Reproduce Detailed steps to reproduce the behavior:

  1. Turn on screen reader.
  2. Press "Tab" to navigate to Widget and press "Enter".
  3. Once widget is open press "Down Arrow" to go to "AND/OR" filter option
  4. While focus is on "AND" the screen reader will read "Radio Button 1 of 3"
  5. Pressing "Down Arrow" will bring focus to "OR" and the screen reader will read "Radio Button 3 of 3"

Expected behavior While navigating through the AND/OR filter with the screen reader should say "Radio Button 1 of 2" for "AND" and "Radio Button 2 of 2" for "OR".

Desktop (please complete the following information):

kasperbolarsen commented 1 month ago

Will you be able to implement these changes or have someone in your org implementing it? Be advised that PnP Modern Search is NOT associated with Microsoft and we are not required to follow various guidelines regarding the user interface. We are community driven and every PR is made by volunteers