search

microsoft-search / pnp-modern-search

Home of PnP Modern Search solutions, helping you move from classic to modern SharePoint and beyond
https://microsoft-search.github.io/pnp-modern-search
Other
390 stars 341 forks source link

Using KQl to filter search results in microsoft search #4087

Closed akshataggrwal closed 2 weeks ago

akshataggrwal commented 2 weeks ago

Using KQL to filter search results while using microsoft search instead of aggregation filters.

Issue Reference - https://github.com/microsoft-search/pnp-modern-search/issues/3934

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wobba commented 2 weeks ago

I think we should still send as FQL, but add multiple rows with one row per each. At least for the AND clause. And a PR which comments out lines of code is not good.

wobba commented 2 weeks ago

Created #4090 which also support dates in KQL. I simplified and use .. for date ranges, which means GE and LT for start and end date. Feel free to test it properly before merging.

akshataggrwal commented 1 week ago

Hi @wobba - Thanks for the updates. I tested the changes in your PR(4090) locally for 'externalItem' entity type and it is working as expected.

Is it reasonable to assume for this to available in next release?

wobba commented 1 week ago

Thank you for test @akshataggrwal. I'll merge it and get a release going.