microsoft-search / pnp-modern-search

Home of PnP Modern Search solutions, helping you move from classic to modern SharePoint and beyond
https://microsoft-search.github.io/pnp-modern-search
Other
388 stars 341 forks source link

SPFx-upgrade-search-extensibility to v1.20.0 #4107

Open NishkalankBezawada opened 6 days ago

NishkalankBezawada commented 6 days ago

SPFx-upgrade-search-extensibility to v1.20.0

I have succesfully built the project, without any errors.

image

I was unable to upgrade search-parts as search-extensibility should need to align with @microsoft/sp-core-library@1.20.0. Hence will be creating a seperate Pull request for upgrade of search-parts.

Thanks, Nish

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wobba commented 2 days ago

No need to update this until web parts build above 1.18.2. Already made a 1.19 version - but not of any use.

NishkalankBezawada commented 19 hours ago

No need to update this until web parts build above 1.18.2. Already made a 1.19 version - but not of any use.

Hello @wobba,

Thanks for the update.

But since search-parts webparts, which is using 'search-extensibility' as a package, upgrading webparts gives as below errors, as search-extensibility will have dependencies of versions 1.19.0 and clashes with the versions 1.20.0

image

So, I thought that it would be good if we can first upgrade the 'search-extensibility' and then the webparts.

Thanks, Nishkalank