microsoft / 0xDeCA10B

Sharing Updatable Models (SUM) on Blockchain
https://aka.ms/0xDeCA10B-blog1
MIT License
556 stars 134 forks source link

[simulation] Use normalization like in the demo. #135

Open juharris opened 2 years ago

juharris commented 2 years ago

In the demo, normalization is done before updating the dense perceptron and dense nearest centroid classifiers, but the simulation doesn't use normalization.

Normalization is used to avoid submissions with large values that would corrupt the model. Using normalized vectors might be bad for these models but it seems like a necessary guard to have on-chain.

hs094 commented 2 years ago

Can you describe more about this Issue?

juharris commented 2 years ago

We enforce that data in normalized before adding in DensePerceptron.sol and some other classes in the demo folder but we don't normalize data before processing it in the simulation.