microsoft / 2LCS

Lifecycle Services Companion App for administrators
MIT License
104 stars 55 forks source link

Optionally populate external IP address when creating firewall exceptions #100

Closed milnet92 closed 3 months ago

milnet92 commented 3 months ago

Related to #97

Added a new parameter in settings and form parameter, defaulted to false

image

Whenever the user enters the form AddNSG.cs, a request is done to https://icanhazip.com to retrieve the external IP and populates it into the IP textbox.

I did not include the option to get the IP from another service since icanhazip is a reliable source used by many other projects and other services may have different approaches other than plain text IP.

milnet92 commented 3 months ago

@microsoft-github-policy-service agree