search

microsoft / 2LCS

Lifecycle Services Companion App for administrators
MIT License
104 stars 55 forks source link

Region support #70

Closed flauest closed 1 year ago

flauest commented 1 year ago

Hi, I use 2LCS a lot, but now we are getting LCS project that are from the new regions in LCS such as Europe and Norway. Any way that 2LCS can support projects from other that then United States? /Flemming

FH-Inway commented 1 year ago

The lcs.dynamics.com url is currently hard coded in a couple of files, see https://github.com/search?q=repo%3Amicrosoft%2F2LCS%20lcs.dynamics.com&type=code

A solution would at least require to make that configurable and expose that configuration somewhere in the ui. Not sure if further changes would be required.

tfa-dk commented 1 year ago

A quick search and replace of lcs.dynamics.com to eu.lcs.dynamics.com works. I can start an environment, login to rdp and application. But the 2 2lsc.exes share a data cache, so you have to do a logout and login to see the right environments.

/Torben

FH-Inway commented 1 year ago

I played around with this and added some basic support for different regions in the parameters of 2LCS. Note that after changing the urls, you need to log out and log in again.

If you want to test this version, you can go to release 0.31.0 in my fork and download a compiled version there (or just compile the pull request version yourself).

Unfortunately I currently do not have access to LCS projects that are not in the US/global region, so I can't test it fully myself.

image

flauest commented 1 year ago

When using these parameters image I get an logon error: image

Thx for doing the development. I would like a picking list for Geo, as I will be going to work in both US and EU every day.

flauest commented 1 year ago

If you like I can invite you to a project so you have some were to test

FH-Inway commented 1 year ago

@flauest Thanks for testing!

For the LCS Diagnostic Url, your screenshot shows 2 dots after eu: 

https://diag.eu..lca.dynamics.com
                ^

I also got issues (although different from what you describe) with this url value. After removing the duplicate dot, it worked again. Could you try this?

Regarding picking list for geo: I hear you. While doing my changes, I noticed that @TomekMelissa seems to have started adding support for this, see https://github.com/microsoft/2LCS/blob/4914fbd91d25cc432378a818ab056b74cfe8d2f7/2LCS/Enumerations.cs#L54 Would love to make this more user friendly, but that will take some time.

FH-Inway commented 1 year ago

If you like I can invite you to a project so you have some were to test

That would be awesome, thank you!

Update: I guess you need an email address to do that :) firstname.lastname@inway.de Find my first and last name on my github profile or look me up on Microsoft's Insider Feedback Yammer (if you have access there). Don't want to spell my email out here because of bots and spam.

flauest commented 1 year ago

After correcting my typo I got it working. I can now see my 2 projects and I can open a rdp. So the parameters are working

FH-Inway commented 1 year ago

@flauest This is now part of version 0.41.0.

@TomekMelissa I took the liberty of merging #76 and creating a new version with release notes. If nothing comes up until next week, I suggest we remove the prerelease flag and make it the latest version.