search

microsoft / 2LCS

Lifecycle Services Companion App for administrators
MIT License
104 stars 55 forks source link

Can't get a list of packages for MS-hosted environments #89

Closed CHJanusz closed 9 months ago

CHJanusz commented 9 months ago

With the current implementation of HttpClientHelper.GetPagedDeployablePackageListUrl when trying to get a list of deployable packages for MS-hosted environment the list is empty. It looks like the reason is URL returned by this method. For CHE it works fine as {LcsUrl}/Environment/GetPagedDeployablePackageList[...] returns the list, but for MS-hosted env the list is empty. When in turn you use {LcsUrl}/EnvironmentServicingV2/GetPagedDeployablePackageList[...] it returns packages for MS-hosted env, but not for a CHE. It seems that if MS will not make EnvironmentServicingV2 return the list for both types of environments HttpClientHelper.GetPagedDeployablePackageListUrl method should return a different URL according to environment type.

FH-Inway commented 9 months ago

Thanks for reporting. I will take a look. If you feel up to it, let me know if you are interested in working on this. It seems you already found the locations in the code that need to be changed.

CHJanusz commented 9 months ago

Sure, I've created a pull request :)

FH-Inway commented 9 months ago

And merged #90 Thanks a lot for the contribution, I will do a new release later this weekend.

FH-Inway commented 9 months ago

Release v.0.48.0 is out! Thanks again.