microsoft / 2LCS

Lifecycle Services Companion App for administrators
MIT License
104 stars 55 forks source link

Optionally Prepopulate IP Address when adding Firewall Exception #97

Closed tnoor-kr closed 3 months ago

tnoor-kr commented 4 months ago

It would be a productivity boost to prepopulate one's public IP when adding a firewall exception. We could make a call to a free service like https://icanhazip.com and use that to prepopulate the input or add as a suggestion below it. This could be exposed under the parameters as optional along with the option to configure the URL if the user prefers a different service.

If you're open to this idea, I'd be happy to do a PR on it.

ms-teams-20240716-000045

FH-Inway commented 4 months ago

Hi, welcome to the repo and thanks for the suggestion. Sure, sounds like fun, let's do it 👍

FH-Inway commented 3 months ago

@milnet92 Thanks for the pr (the 100th btw. 🎉 ), looking good, this is now available in version 0.52.0

@tnoor-kr Let us know if this works for you.

tnoor-kr commented 3 months ago

Thank you for getting to this sooner than I could have. I just tried it out and it populated the IP instantly.