Closed mikhailnikolaev closed 5 years ago
@awf, @tomjaguarpaw, I've moved us jacobian part merging into two columns to output
function of the test class. New plots are attached to the PR. I attach old plots to this message for comparision. Note, that I've merged PyTorch new Hand version to the branch, so, little changes in PyTorch plot behaviour are correct. Also, new X-axis for Hand is used. As you can see there are not any significant changes in time for Tensorflow after refactoring. But I like the new version of the code, because it becames clearer, so, I've added the commit with changes to the PR.
Note: there are only graphs for complicated jacobian calculating, because only these plots could be changed.
This looks excellent to me. Did we discuss it last Wednesday?
Yes we did. Also we wanted to change code a bit and create new plots. That has been done
Good, well I'm happy with it. I think we should merge it. If @awf has comments then we can address them post-merge.
Tensorflow Hand objective differentiation test class is implemented.
Note: Tensorflow 2.0 is used. All calculations are made in eager execution mode.
Graphs
Jacobian
Jacobian ÷ objective
Objective
Objective ÷ manual