search

microsoft / ADBench

Benchmarking various AD tools.
MIT License
107 stars 40 forks source link

Using Sort-Object #160

Closed mikhailnikolaev closed 5 years ago

mikhailnikolaev commented 5 years ago

This PR is done due to some bug in the current array parameter sorting.

A sort alias for the comandlet Sort-Object was used in the PowerShell code. It works fine in Windows, but doesn't in Linux, because there is an utility called sort in Linux. That's why in PowerShell Core there is no alias sort for Sort-Object, so calling sort the script uses Linux utility sort, that sorting values alphabetically by default. It leads to some strange behaviour, for example the script calculates GMM for d = 10 before d = 2. So, now the alias using is removed.

tomjaguarpaw commented 5 years ago

Interesting and well spotted. How did this affect the weekly run?

mikhailnikolaev commented 5 years ago

Interesting and well spotted. How did this affect the weekly run?

You can see the result on http://adbenchwebviewer.azurewebsites.net/ In short, this leads to unpropper guaranteed timeout prediction. E.g. if GMM K=100 is finished due to a timeout, then GMM K=5, 25, 500 will not be run, because alphabetically they follow 100