search

microsoft / ADBench

Benchmarking various AD tools.
MIT License
107 stars 40 forks source link

Dmkats/buildfix #178

Closed msdmkats closed 4 years ago

msdmkats commented 4 years ago

Fixes #176 Build: https://msrcambridge.visualstudio.com/Knossos/_build/results?buildId=48485

The problem was that cmake's find_package found Python 3.8, instead of the default 3.7. Python 3.8 is not yet supported by all pip packages.

tomjaguarpaw commented 4 years ago

Well done for tracking that down. The way that ADO provides versions of things that you didn't ask for can be very annoying.

msdmkats commented 4 years ago

It was not ADO, it was CMake. Both python versions (and many more, in fact) are present on the build machine, there's a task that we use that makes the chosen version the default one.

But then CMake uses some non-obvious algorithm and picks the wrong one, unless forced to do otherwise.

tomjaguarpaw commented 4 years ago

Both python versions (and many more, in fact) are present on the build machine, there's a task that we use that makes the chosen version the default one.

Yes, I know, and I don't like it. It makes these sorts of bugs more likely to occur. Ideally the only software installed on the build machine would be that which is explicitly chosen in the build definition. I'm sure that would not be straightforward to achieve though. Anyway, this is rather tangential ...