Time info collecting - Githubissues

microsoft / ADBench

Benchmarking various AD tools.

MIT License

107 stars 39 forks source link

Time info collecting #180

Closed mikhailnikolaev closed 4 years ago

mikhailnikolaev commented 4 years ago

The plot-graphs.py script now collects all time information, that was used for creating graphs, into the single JSON file. Then the script can use such a file for creating graphs without any information generated by the global runner. For specifying such a behaviour the argument --use-file <file> is used.

This PR is linked to issue #25.

tomjaguarpaw commented 4 years ago

To expand a bit, this module now performs (or should perform) two conceptually distinct tasks:

Generate and collate graph data from a collection of files scattered around the filesystem and put it into a single object
Plot graphs from the single object

(additionally it deals with loading and saving the single object to the filesystem, but that's a triviality)

It's very important that these two conceptually distinct tasks are kept distinct in the implementation too (i.e. that they be decoupled).

mikhailnikolaev commented 4 years ago

I think I should split this PR into the following parts:

[x] Separating get values and drawing graph.
[x] Generating and saving plot data. Using plot data for creating graphs.
[x] Performing changes, requested in https://github.com/awf/ADBench/pull/180#discussion_r361457678
[x] Refactoring IO paths creating (e.g. moving dir vars to the local level from the global one).
[x] Using specified file for creating graphs.
[x] Doc string and output reference fixing/changing.
[x] Documentation changes.

@tomjaguarpaw, what do you think?

tomjaguarpaw commented 4 years ago

For me, splitting it would help a lot and make it easier to review. Thanks!