search

microsoft / ADBench

Benchmarking various AD tools.
MIT License
102 stars 38 forks source link

IO paths creating refactoring [part of #180] #185

Closed mikhailnikolaev closed 4 years ago

mikhailnikolaev commented 4 years ago

This PR contains a part of changes from the closed PR #180. It is the fourth part of the list, described here https://github.com/awf/ADBench/pull/180#issuecomment-569066919

tomjaguarpaw commented 4 years ago

This looks like exactly the right thing to do, but should we pass static_output_dir and plotly_output_dir to print_messages?

mikhailnikolaev commented 4 years ago

This looks like exactly the right thing to do, but should we pass static_output_dir and plotly_output_dir to print_messages?

Actually, I think, that the refernce should be static. I know that I was the one who made it non-static, but now I've changed my mind. Firstly, all info about output and input dirs the user gets in the console when the script working. Secondly, in the future change the output dir is variative, I mean its path depend on giving (or not) --use-file argument. So, my proposal is to make the reference in the way it is now. Or do you disagree with me?

tomjaguarpaw commented 4 years ago

I think you are correct because static output is simpler and it is not critical to have it dynamic. Let's keep things as simple as we can.

mikhailnikolaev commented 4 years ago

This is great.

Thanks)