search

microsoft / ADBench

Benchmarking various AD tools.
MIT License
102 stars 38 forks source link

Using specified plot data file [part of #180] #186

Closed mikhailnikolaev closed 4 years ago

mikhailnikolaev commented 4 years ago

Now the script can use specified plot data file instead of the global runner output files.

This PR contains a part of changes from the closed PR #180. It is the fifth part of the list, described here https://github.com/awf/ADBench/pull/180#issuecomment-569066919

mikhailnikolaev commented 4 years ago

It looks like get_out_dir_and_plot_data should be two separate functions, because it does one of two completely independent things depending on whether use_file.

Not exactly. In the case of --use-file we need to extract the value of the cmd argument both for creating output dir and getting plot data. Now we do it only once. I thought, it was a kind of optimization, but maybe it's better to do it twice instead of creating complicated code