search

microsoft / AI-System

System for AI Education Resource.
https://microsoft.github.io/AI-System/
Creative Commons Attribution 4.0 International
3.63k stars 450 forks source link

Issues in chapter 6 #76

Closed YanjieGao closed 2 years ago

YanjieGao commented 2 years ago

请移除保持章节一致性

image

YanjieGao commented 2 years ago

image image

YanjieGao commented 2 years ago

添加引用 image

YanjieGao commented 2 years ago

X-Y 轴简介

image

YanjieGao commented 2 years ago

[概念](raw link)防止暴露raw link

image

YanjieGao commented 2 years ago

章节小节与参考文献

image

YanjieGao commented 2 years ago

参考术语表，并将当前 中文概念(英文概念)加入术语表

image

YanjieGao commented 2 years ago

图号 image

YanjieGao commented 2 years ago

![Uploading image.png…]()

章节小节和引用

YanjieGao commented 2 years ago

增加table 名，隐藏链接 image

YanjieGao commented 2 years ago

code放进 ''' '''中保持章节格式一致

image

YanjieGao commented 2 years ago

image 代码和Figure from用中文

YanjieGao commented 2 years ago

章节名文字润色 image

YanjieGao commented 2 years ago

请estimate allreduce的通信好处。 并设计一个问题，让读者预估和设计算法。Protocal部分是有潜力设计算法

image

YanjieGao commented 2 years ago

章节小节和引用

image

YanjieGao commented 2 years ago

Dear，请把lab作为sub chapter加入章节 https://github.com/microsoft/AI-System/tree/main/Labs/BasicLabs/Lab4

参考chapter 7,8

YanjieGao commented 2 years ago

Dear 请把lab 7加入章节https://github.com/microsoft/AI-System/tree/main/Labs/AdvancedLabs/Lab7 参考chapter7,8

YanjieGao commented 2 years ago

https://github.com/microsoft/AI-System/blob/main/Textbook/src/Checker.py Please avoid these errors. We will try to add more in this like "Coding conventions"

YanjieGao commented 2 years ago

通过[]()隐藏链接

image

YanjieGao commented 2 years ago

图号参考chapter 7 image

YanjieGao commented 2 years ago

[]() to hide link image

YanjieGao commented 2 years ago

中文翻译 image

YanjieGao commented 2 years ago

需要稍加文字解释图中拓扑 image

YanjieGao commented 2 years ago

image 加文字解释或者引用

YanjieGao commented 2 years ago

汉化 image

YanjieGao commented 2 years ago

概念解释

image

YanjieGao commented 2 years ago

汉化 image

YanjieGao commented 2 years ago

放入代码块中

image

YanjieGao commented 2 years ago

大小写和参考文献 image

YanjieGao commented 2 years ago

章节目录，参考chapter 7 image

YanjieGao commented 2 years ago

引用不统一

image

YanjieGao commented 2 years ago

长篇论文可以放入参考链接中

image

YanjieGao commented 2 years ago

中文(英文) 形式？ image

YanjieGao commented 2 years ago

概念引用和中文术语 image

YanjieGao commented 2 years ago

图中可以追加一定的对应标注或箭头，让文字和图片对应 image

YanjieGao commented 2 years ago

去空格 image

YanjieGao commented 2 years ago

命名不一致 image

YanjieGao commented 2 years ago

Dear Author, 请同时阅读其他章节内容, 我们需要章节间内容的一些叙事铺垫, 内容呼应和内容去重，当前图书不太适合完全孤立的书写各章，请大家和各章节作者再就这些如果发现的问题单独沟通 。

尤其第一章会recall各个章节，请大家Double check内容是否需要调整。 参考： https://github.com/microsoft/AI-System/blob/main/Textbook/%E7%AC%AC1%E7%AB%A0-%E4%BA%BA%E5%B7%A5%E6%99%BA%E8%83%BD%E7%B3%BB%E7%BB%9F%E6%A6%82%E8%BF%B0/1.4-%E6%B7%B1%E5%BA%A6%E5%AD%A6%E4%B9%A0%E6%A0%B7%E4%BE%8B%E8%83%8C%E5%90%8E%E7%9A%84%E7%B3%BB%E7%BB%9F%E9%97%AE%E9%A2%98.md

YanjieGao commented 2 years ago

可以映射为传统的通信拓扑，并附上相应的传统拓扑的吞吐和时间预估。 例如，bus类型，switch类型，mesh类型等。进而Guide优劣势和启发读者做task placement optimization aware the topo

image

YanjieGao commented 2 years ago

Hello 山哥，对本章是否有可能通过一些图总览整个内容和本领域的问题，引出各小节内容？有几种形式供参考

image

image

YanjieGao commented 2 years ago

https://github.com/microsoft/AI-System/pull/94